-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded string operations #9910
Conversation
Results for GUI-tests https://drone.owncloud.com/owncloud/client/12481/6/1 💥 The GUI tests failed. GUI Logs: https://cache.owncloud.com/public/owncloud/client/12481/guiReportUpload/index.html |
442bc5e
to
45182d8
Compare
@@ -45,8 +45,8 @@ int oc_mkdir(const QString &path) | |||
static mbchar_t wd_buffer[WD_BUFFER_SIZE]; | |||
|
|||
typedef struct { | |||
QByteArray result; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the value of that unit test by now.....
d2f080e
to
2444d98
Compare
2444d98
to
c5c84a5
Compare
Kudos, SonarCloud Quality Gate passed! |
CI hanged with the following message: starting tests
11:21:42:280 Info: Starting server of Squish version 6.7.3 Alpha.
11:21:42:288 Info: Listening on 0.0.0.0:4322
11:21:42:288 Info: Listening on ws://127.0.0.1:45009?zWKcD9u1ONE8SoLEWr_N
11:21:42:288 Info: Announcing server presence via SSDP Tests are not running. Restarted CI. |
|
||
if (vfs && vfs->statTypeVirtualFile(file_stat.get(), &handle->ffd)) { | ||
if (vfs && vfs->statTypeVirtualFile(file_stat.get(), &handle->ffd)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation is more off than it used to be. Please revise and if necessary fix for the entire file once and for all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation mess will be fixed in follow-up PR.
No description provided.