Ensure we remove a child job from before we trigger the next #9926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results for GUI-tests https://drone.owncloud.com/owncloud/client/12514/6/1 |
TheOneRing
force-pushed
the
work/fix_SyncConflictTest
branch
2 times, most recently
from
73daf1a
to
120b86c
Compare
fmoc
suggested changes
Jul 22, 2022
A delete job that triggered slotComputeContentChecksum could reach slotComputeTransmissionChecksum before the delete job was removed from _jobs. The upload job would then not start the first chunk upload and be stalled for ever. Fixes: #9725
TheOneRing
force-pushed
the
work/fix_SyncConflictTest
branch
from
fbaf1fd
to
7a195ea
Compare
TheOneRing
force-pushed
the
work/fix_SyncConflictTest
branch
from
7a195ea
to
3e20f55
Compare
fmoc
approved these changes
Jul 22, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A delete job that triggered slotComputeContentChecksum could reach slotComputeTransmissionChecksum before the delete job was removed from _jobs.
The upload job would then not start the first chunk upload and be stalled for ever.
Fixes: #9725