add tests for counting number of etag element in response of versione…

…d file
owncloud · Feb 24, 2021 · 2ccc95d · 2ccc95d
1 parent e26b71e
commit 2ccc95d
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 0 deletions.
diff --git a/tests/acceptance/features/apiVersions/fileVersions.feature b/tests/acceptance/features/apiVersions/fileVersions.feature
@@ -420,3 +420,13 @@ Feature: dav-versions
     Given user "Alice" has uploaded file with content "uploaded content" to "textfile0.txt"
     When user "Alice" gets the number of versions of file "textfile0.txt"
     Then the number of versions should be "0"
+
+  @issue-ocis-1234
+  Scenario: the number of etag element in response changes according to version of the file
+    Given user "Alice" has uploaded file with content "uploaded content" to "textfile0.txt"
+    And user "Alice" has uploaded file with content "version 1" to "textfile0.txt"
+    And user "Alice" has uploaded file with content "version 2" to "textfile0.txt"
+    When user "Alice" gets the number of versions of file "textfile0.txt"
+    Then the HTTP status code should be "207"
+    And the number of etag element in the response should be "2"
+    And the number of versions should be "2"
diff --git a/tests/acceptance/features/bootstrap/WebDav.php b/tests/acceptance/features/bootstrap/WebDav.php
@@ -448,6 +448,31 @@ public function theNumberOfVersionsShouldBe($number) {
 		);
 	}
 
+	/**
+	 * @Then the number of etag element in the response should be :number
+	 *
+	 * @param int $number
+	 *
+	 * @return void
+	 * @throws Exception
+	 */
+	public function theNumberOfEtagElementInTheResponseShouldBe($number) {
+		$resXml = $this->getResponseXmlObject();
+		if ($resXml === null) {
+			$resXml = HttpRequestHelper::getResponseXml(
+				$this->getResponse(),
+				__METHOD__
+			);
+		}
+		$xmlPart = $resXml->xpath("//d:getetag");
+		$actualNumber = \count($xmlPart);
+		Assert::assertEquals(
+			$number,
+			$actualNumber,
+			"Expected number of etag element was '$number', but got '$actualNumber'"
+		);
+	}
+
 	/**
 	 * @Given /^the administrator has (enabled|disabled) async operations$/
 	 *