Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option to exclude directories and files from file system scan #10792

Closed
j-ed opened this issue Aug 31, 2014 · 5 comments
Closed

Comments

@j-ed
Copy link
Contributor

j-ed commented Aug 31, 2014

Expected behavior

It should be possible to exclude directories and files from being added to the cache during a file system scan. In a first step a general configuration option should be added to define excludes, in a second step it might be worse to define excludes based on a file, e.g. '.oc-scan-excludes', which can be stored in a directory which contains directories and files to be excluded.

Actual behavior

All directories and files are scanned during a file system scan which also include e.g. unix hidden files which are starting with a dot, or Windows profile data, e.g. profile.V2/... (which might contain 10-100k files).

Steps to reproduce

Check the debug output during a file system scan.

Environment

Server Configuration

OS: Linux 3.2.54
Web server: Apache2 2.4.10
Database: MySQL 5.1.73
PHP version: 5.4.26
ownCloud version: 7.0.2

Client Configuration

Browser: Firefox 31.0
Operating system: Windows 7

@PVince81
Copy link
Contributor

PVince81 commented Sep 1, 2014

Is the use case mostly for external storage ? (possibly SMB)

@PVince81
Copy link
Contributor

PVince81 commented Sep 1, 2014

If the directories are excluded from the scan, it means they'd never appear inside of ownCloud as if they didn't exist.

It also means that if you exclude a folder called "excluded" from the scan, the code needs to make sure it's not possible for a user to create a folder called "excluded", even though it doesn't appear in the UI / file cache.

@icewind1991 what do you think ?

@j-ed
Copy link
Contributor Author

j-ed commented Sep 1, 2014

@PVince81 As long as local mounts are also categorized as external storage (beside SMB, NFS, WebDAV mounts, etc.) I tend to agree to your assumption. I learned that different OSes are using different ways to hide directories and data from being displayed, like e.g.:

./.cache
./.config
./.mc
./@eaDir
./profile.V2
./ZbThumbnail.info
./iPod Photo Cache
./.htaccess
...

@PVince81
Copy link
Contributor

Solved with #19235.
This not only excludes from scan but also from being visible in the web UI and Webdav.

Because excluding from scan alone isn't enough anyway as the files would be found later at access time.

@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants