Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Part files are not considered for quota while they are uploaded #40343

Open
jnweiger opened this issue Sep 6, 2022 · 4 comments
Open

[QA] Part files are not considered for quota while they are uploaded #40343

jnweiger opened this issue Sep 6, 2022 · 4 comments
Assignees
Labels

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Sep 6, 2022

Seen while testing #39895 with 10.11.0-beta.1

The initial description for this PR has
"

  • Part files will also be considered for quota while they're being
    uploaded
    "

I believe this part of the PR was not implemented:

User2 has 40 MB quota. He has 5.4 MB already, and is uploading a 33 MB file (with chunks of 10 MB).
The used quota remains at 5.4 MB until the very last moment, when the file is assembled.

image


image


Similarly, when the uploading a 9.5 MB file (no chunking, directly into the target directory with a *.part file) the quota does not see the *.part file. Only after assembly, it jumps up.

Expected behaviour:

  • Quota used also counts part files and chunks.

Everything else in #39895 seems to work fine.

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically closed.

@jvillafanez
Copy link
Member

I'm not sure if we can anything... I think the part storage doesn't count for the quota, and maybe it shouldn't count: even if you don't have enough quota for the file, the file could end up in an external storage where quota doesn't apply.

The only thing we can discuss is whether we should remove the chunks or not right after the failed upload. Removing the chunks make sense, but clients might retry the upload later just uploading the missing chunks (not sure if it's possible or not)

@jvillafanez
Copy link
Member

The only thing we can discuss is whether we should remove the chunks or not right after the failed upload. Removing the chunks make sense, but clients might retry the upload later just uploading the missing chunks (not sure if it's possible or not)

Likely related #40892

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants