fix: remove just uploaded files in case of error - also for storages …

[DeepDiver1975]

…which do not support part files

Description

Storage which does not support part files (external storage and s3) can leave broken files in the user space.
This change cleans up these broken files.

Alternative approach to #40891 - which is breaking apis too badly ...

Related Issue

• https://github.com/owncloud/enterprise/issues/5903

How Has This Been Tested?

One has to force a failure during upload - e.g. adding one byte to the expected size at

core/apps/dav/lib/Connector/Sabre/File.php

Line 229 in 20da6a8

$expected = $_SERVER['CONTENT_LENGTH'];

• have trash enabled
• have encryption enabled
• to test with posix storage
• to test with s3 storage
• to test with different external storage
• to test with and without chunking (smaller and greater 10MB

1. Upload file
2. see the error message on the browser
3. assert that the file is not on storage
4. assert that the file is not in DB

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[jnweiger]

Confirmed. This fixes the broken files after timeout.

[pako81]

merge it?

[phil-davis]

merge it?

AFAIK it is fine to merge. Who decides to press the merge button these days?

[DeepDiver1975]

I would like to add some unit tests for this ..... but I can do this in a follow up pr as well ....

[phil-davis]

@DeepDiver1975 also needs a changelog entry.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

84.6% Coverage
0.0% Duplication

[DeepDiver1975]

now squashed and with changelog

[phil-davis]

@pako81 this has been reviewed by multiple people and approved.
I guess we should merge it.