-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New collumn of execution time added in db schema of oc_jobs #27144
Merged
Merged
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
050f031
New collumn of execution time added in db schema of oc_jobs
noveens 4a4fbb5
Finally completed adding a column to oc_jobs through migration.
noveens c86fa8a
trailing space.
noveens fab44e2
Tests updation not required.
noveens 108444d
New method added to store execution duration in oc_jobs
noveens 7ca8316
wrong column fixed
noveens 6929f81
called setExecutionTime at wrong place, fixed now.
noveens 9fe7a85
default value of execution time set to -1, logging enabled.
noveens 04e7a46
Logging messages changed
noveens 1f269a9
logging messages format changed
noveens 02659b1
debug statements removed
noveens bd87953
tests updated for oc_jobs
noveens 008f78a
defination of setExecutionTime() added in public.
noveens c43ed8c
trying to pass jenkins
noveens b394ec6
trying to pass jenkins
noveens 8b6dc6d
trying to pass jenkins
noveens 7cd78c6
config.sample.php permissions changed
noveens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
<?php | ||
|
||
namespace OC\Migrations; | ||
|
||
use Doctrine\DBAL\Schema\Schema; | ||
use OCP\Migration\ISchemaMigration; | ||
|
||
/** | ||
* DB updation for oc_jobs table | ||
*/ | ||
class Version20170213215145 implements ISchemaMigration { | ||
|
||
public function changeSchema(Schema $schema, array $options) { | ||
$prefix = $options['tablePrefix']; | ||
if ($schema->hasTable("${prefix}jobs")) { | ||
$table = $schema->getTable("${prefix}jobs"); | ||
|
||
$table->addColumn('execution_duration', 'integer', [ | ||
'notnull' => true, | ||
'length' => 5, | ||
'default' => -1, | ||
]); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this
echo
and thegettype
belowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, forgot to remove the debug statements.
Updated changes pushed.