Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] subadmin and app-enable-disable-list are notToImplementOnOCIS #37873

Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 2, 2020

Description

The features related to sub-admin, and app enable/disable/list are not to implement on OCIS. Tag them so that they do not get run accidentally in OCIS CI. This will reduce the number of unnecessary scenarios to be added to expected-failures in OCIS.

If similar features are created in OCIS (e.g. enable/disable of extensions...) then those will be implemented in some quite different way. So the core test scenarios are not likely to be relevant anyway.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Sep 2, 2020
@phil-davis phil-davis force-pushed the subadmin-and-app-enable-disable-notToImplementOnOCIS branch 2 times, most recently from 60cb398 to 4454f3e Compare September 2, 2020 11:54
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #37873 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37873   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19403    19403           
=========================================
  Files          1285     1285           
  Lines         75823    75823           
  Branches       1336     1336           
=========================================
  Hits          49096    49096           
  Misses        26333    26333           
  Partials        394      394           
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (ø) 19403.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd1e3f...94ba750. Read the comment docs.

@phil-davis phil-davis force-pushed the subadmin-and-app-enable-disable-notToImplementOnOCIS branch from 40835ab to 94ba750 Compare September 2, 2020 14:13
@phil-davis phil-davis merged commit 92b45e1 into master Sep 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the subadmin-and-app-enable-disable-notToImplementOnOCIS branch September 2, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants