Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Fix add users in provisioning api when testing on ocis #37874

Merged
merged 2 commits into from
Sep 2, 2020

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Sep 2, 2020

Description

This PR fixes add users such that when run on ocis, users are created with email.

Related Issue

How Has This Been Tested?

core CI and owncloud/ocis#517

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jasson99 jasson99 self-assigned this Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #37874 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37874   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19403    19403           
=========================================
  Files          1285     1285           
  Lines         75823    75823           
  Branches       1336     1336           
=========================================
  Hits          49096    49096           
  Misses        26333    26333           
  Partials        394      394           
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (ø) 19403.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd1e3f...ed94c61. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #37874 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37874   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19403    19403           
=========================================
  Files          1285     1285           
  Lines         75823    75823           
  Branches       1336     1336           
=========================================
  Hits          49096    49096           
  Misses        26333    26333           
  Partials        394      394           
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (ø) 19403.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd1e3f...ed94c61. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #37874 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37874   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19403    19403           
=========================================
  Files          1285     1285           
  Lines         75823    75823           
  Branches       1336     1336           
=========================================
  Hits          49096    49096           
  Misses        26333    26333           
  Partials        394      394           
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (ø) 19403.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd1e3f...ed94c61. Read the comment docs.

@phil-davis phil-davis force-pushed the fixAddUsersForProvisioningApiOcis branch from ed94c61 to e8cc9af Compare September 2, 2020 14:51
@phil-davis phil-davis changed the title [Tests-Only]Fix add users in provisioning api when testing on ocis [Tests-Only] Fix add users in provisioning api when testing on ocis Sep 2, 2020
@phil-davis phil-davis self-requested a review September 2, 2020 14:59
@phil-davis phil-davis force-pushed the fixAddUsersForProvisioningApiOcis branch from a7250dc to 1199ef8 Compare September 2, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants