Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] relax expected Location regex #38180

Merged
merged 1 commit into from
Dec 2, 2020
Merged

[tests-only] relax expected Location regex #38180

merged 1 commit into from
Dec 2, 2020

Conversation

individual-it
Copy link
Member

Description

make the regex broader to also match reva location urls e.g. http://revad-services:12001/data/tus/e4d65ee9-f7c0-4ef5-ab68-92753552560e

Related Issue

part of owncloud/product#153

How Has This Been Tested?

cs3org/reva#1353

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@swoichha swoichha mentioned this pull request Dec 2, 2020
Merged
swoichha
swoichha approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@swoichha swoichha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 9c50986 into master Dec 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the relaxRegexTUSCreateTest branch December 2, 2020 08:29
This was referenced Dec 3, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@swoichha swoichha swoichha approved these changes

Assignees

@individual-it individual-it

Labels
3 - To Review dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@individual-it @phil-davis @swoichha