Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only]Adjust correct tags for createPublicLink tests #38803

Merged
merged 1 commit into from
Jun 8, 2021
Merged

[Tests-Only]Adjust correct tags for createPublicLink tests #38803

merged 1 commit into from
Jun 8, 2021

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Jun 3, 2021 •
edited
Loading

Description

This PR adjusts the notToImplementOnOCIS tags in the scenarios of createPublicLinkShare.feature which are not to be implemented in OCIS immediately.

Related Issue

Motivation and Context

Some of the scenarios of features which are not expected to be implemented in OCIS immediately were also run in OCIS-CI, which actually wasted resources and time. So the notToImplementOnOCIS tags on such scenarios were necessary.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jasson99 jasson99 force-pushed the notToImplementOnOcis branch 2 times, most recently from d506aaa to f08b9ff Compare June 3, 2021 10:02
@jasson99 jasson99 self-assigned this Jun 3, 2021
@jasson99 jasson99 changed the title [Tests-Only]Not to implement on ocis [Tests-Only]Adjust correct tags for createPublicLink tests Jun 3, 2021
@jasson99 jasson99 marked this pull request as ready for review June 4, 2021 06:41
Talank
Talank reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the already existing reviews

swoichha
swoichha reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@swoichha swoichha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

phil-davis
phil-davis reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These complicated scenarios with combinations of settings (Given) and actions (When) and checks (Then) are hard to describe in a 1-line Scenario description!

tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature Outdated Show resolved Hide resolved
@jasson99 jasson99 requested a review from phil-davis June 4, 2021 10:42
@jasson99 jasson99 force-pushed the notToImplementOnOcis branch 3 times, most recently from f196e91 to e5a43d8 Compare June 7, 2021 08:47
@jasson99 jasson99 requested a review from dpakach June 7, 2021 09:11
dpakach
dpakach reviewed Jun 7, 2021
View reviewed changes
Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, One small thing though not very important would be replacing webDavApi to webdav_api_version just to be consistent with existing convention

@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

phil-davis
phil-davis approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 pairs of scenarios down the end that could also be made into Scenario Outlines. But that is not a big problem! Let's merge this.

tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature
And the public download of file "/parent.txt" from inside the last public shared folder using the new public WebDAV API should fail with HTTP status code "404"

@issue-ocis-reva-199 @notToImplementOnOCIS @issue-ocis-2079
Scenario: Delete a folder that has been publicly shared and try to access using the old public WebDAV API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this scenario could be merged with the one above to make a Scenario Outline.

tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature
@@ -752,6 +682,14 @@ Feature: create a public link share
When the public downloads file "parent.txt" from inside the last public shared folder using the new public WebDAV API
Then the value of the item "//s:message" in the response should be "File not found: parent.txt"
And the HTTP status code should be "404"

@issue-ocis-reva-292 @notToImplementOnOCIS @issue-ocis-2079
Scenario: try to download from a public share that has upload only permissions using the old public webdav api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this scenario could be merged with the one above to make a Scenario Outline.

@phil-davis phil-davis merged commit 025715d into master Jun 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the notToImplementOnOcis branch June 8, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swoichha swoichha swoichha left review comments

@dpakach dpakach dpakach left review comments

@Talank Talank Talank left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@SwikritiT SwikritiT SwikritiT left review comments

@phil-davis phil-davis phil-davis approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@jasson99 jasson99

Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jasson99 @phil-davis @swoichha @dpakach @Talank @kiranparajuli589 @SwikritiT