Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] update test scenarios to work with ocis #38827

Merged
merged 1 commit into from
Jun 14, 2021
Merged

[Tests-Only] update test scenarios to work with ocis #38827

merged 1 commit into from
Jun 14, 2021

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Jun 10, 2021 •
edited
Loading

Description

Refactor tests to work with ocis.
These are the issues which were causing many tests to fail in ocis which were noticed when reviewing the expected failures file in ocis.

Related Issue

Motivation and Context

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@dpakach dpakach closed this Jun 10, 2021
@dpakach dpakach reopened this Jun 10, 2021
@ownclouders
Copy link
Contributor

💥 Acceptance tests apiWebdavProperties1-mariadb10.2-php7.4 failed. The build is cancelled...

@dpakach dpakach force-pushed the update-tests branch 2 times, most recently from 9223ffb to fc3de01 Compare June 14, 2021 03:23
@dpakach dpakach marked this pull request as ready for review June 14, 2021 03:24
@dpakach dpakach self-assigned this Jun 14, 2021
@phil-davis phil-davis self-requested a review June 14, 2021 05:49
@phil-davis
Copy link
Contributor

phil-davis commented Jun 14, 2021 •
edited
Loading

@dpakach please write some explanation in the top post. - done

@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 1a65c41 into master Jun 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-tests branch June 14, 2021 11:43
@phil-davis phil-davis mentioned this pull request Jun 15, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@jasson99 jasson99 Awaiting requested review from jasson99

@Talank Talank Awaiting requested review from Talank

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

Assignees

@dpakach dpakach

Labels
dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpakach @ownclouders @phil-davis