Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Add spaces example for apiShareOperationsToShare1 suite #39778

Merged
merged 1 commit into from
Feb 10, 2022
Merged

[tests-only][full-ci] Add spaces example for apiShareOperationsToShare1 suite #39778

merged 1 commit into from
Feb 10, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Feb 9, 2022

Description

Added Spaces for suite apiShareOperationsToShare1

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI
  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis
Copy link
Contributor

phil-davis commented Feb 10, 2022 •
edited
Loading

@SagarGi there are still some mentions of dav-path-version in other scenarios. You could refactor those to be dav_version to make the "variable name" consistent in all the scenarios.

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.6% 92.6% Coverage
0.0% 0.0% Duplication

kiranparajuli589
kiranparajuli589 reviewed Feb 10, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

amrita-shrestha
amrita-shrestha approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phil-davis phil-davis merged commit 18d94e1 into owncloud:master Feb 10, 2022
@SagarGi SagarGi mentioned this pull request Feb 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@phil-davis phil-davis phil-davis approved these changes

@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SagarGi @phil-davis @kiranparajuli589 @amrita-shrestha