Sort groups when requested from DB #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
re-pushed for CI as I can't open the Drone results |
PVince81
force-pushed
the
sort-groups-result
branch
from
c15f7c2
to
30b3724
Compare
This makes for deterministic output, especially on Oracle
PVince81
force-pushed
the
sort-groups-result
branch
from
30b3724
to
4b1330d
Compare
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
============================================
+ Coverage 84.26% 84.27% +0.01%
Complexity 296 296
============================================
Files 21 21
Lines 953 954 +1
============================================
+ Hits 803 804 +1
Misses 150 150
Continue to review full report at Codecov.
|
|
@DeepDiver1975 @dpakach CI is green now, it was indeed the sort order in Oracle. please approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes for deterministic output, especially on Oracle.
Fixes #175