Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add PHP7.2 to stable10 #164

Merged
merged 2 commits into from
Sep 24, 2018
Merged

add PHP7.2 to stable10 #164

merged 2 commits into from
Sep 24, 2018

Conversation

davitol
Copy link
Contributor

@davitol davitol commented Aug 31, 2018

add PHP7.2 to stable10

@davitol davitol self-assigned this Aug 31, 2018
@PVince81 PVince81 self-assigned this Aug 31, 2018
@PVince81 PVince81 added this to the development milestone Aug 31, 2018
@PVince81
Copy link
Contributor

Assigning self to fix the issue, looks non-trivial. Seems a method mock was missing.

@PVince81
Copy link
Contributor

mock issue fixed

@codecov-io
Copy link

codecov-io commented Aug 31, 2018 •
edited
Loading

Codecov Report

Merging #164 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #164   +/-   ##
=========================================
  Coverage     83.61%   83.61%           
  Complexity      300      300           
=========================================
  Files            21       21           
  Lines           952      952           
=========================================
  Hits            796      796           
  Misses          156      156

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf9806c...147433b. Read the comment docs.

@PVince81
Copy link
Contributor

PVince81 commented Sep 5, 2018

Weird. the tests ran locally for me

1) OCA\CustomGroups\Tests\unit\Dav\MembershipNodeTest::testDeleteSelfAsNonAdmin
Undefined index: user_id
/home/travis/build/owncloud/core/apps/customgroups/lib/Service/MembershipHelper.php:215
/home/travis/build/owncloud/core/apps/customgroups/lib/Dav/MembershipNode.php:124
/home/travis/build/owncloud/core/apps/customgroups/tests/unit/Dav/MembershipNodeTest.php:269
2) OCA\CustomGroups\Tests\unit\Dav\MembershipNodeTest::testDeleteAsSuperAdmin
Undefined index: user_id
/home/travis/build/owncloud/core/apps/customgroups/lib/Service/MembershipHelper.php:215
/home/travis/build/owncloud/core/apps/customgroups/lib/Dav/MembershipNode.php:124
/home/travis/build/owncloud/core/apps/customgroups/tests/unit/Dav/MembershipNodeTest.php:304

@PVince81
Copy link
Contributor

Apparently I didn't rerun the tests before pushing... :-S

Fixed now.

patrickjahns
patrickjahns approved these changes Sep 13, 2018
View reviewed changes
Copy link
Contributor

@patrickjahns patrickjahns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

davitol and others added 2 commits September 24, 2018 17:18
@davitol @phil-davis
add PHP7.2 to stable10
1497f95
@phil-davis
Add missing mock result for getGroupMembers
147433b 
getGroupMembers did not return any results from the mock so the called
would get null.

Fixes issue with PHP 7.2 where calling count() with null fails.
@phil-davis
Copy link
Contributor

Rebased to get CI fixes from #167

@phil-davis phil-davis merged commit c2bb933 into master Sep 24, 2018
@phil-davis phil-davis deleted the PHP72stable10 branch September 24, 2018 12:05
@PVince81 PVince81 mentioned this pull request Oct 20, 2018
Closed
24 tasks
@PVince81 PVince81 modified the milestones: development, QA Oct 20, 2018
@davitol davitol mentioned this pull request Dec 3, 2018
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@patrickjahns patrickjahns patrickjahns approved these changes

Assignees

@PVince81 PVince81

@davitol davitol

Labels
3 - To Review QA:team
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@davitol @PVince81 @codecov-io @phil-davis @patrickjahns