-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add PHP7.2 to stable10 #164
Conversation
Assigning self to fix the issue, looks non-trivial. Seems a method mock was missing. |
mock issue fixed |
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
=========================================
Coverage 83.61% 83.61%
Complexity 300 300
=========================================
Files 21 21
Lines 952 952
=========================================
Hits 796 796
Misses 156 156 Continue to review full report at Codecov.
|
Weird. the tests ran locally for me
|
3f4f910
to
df96ea1
Compare
Apparently I didn't rerun the tests before pushing... :-S Fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
df96ea1
to
48f7d41
Compare
getGroupMembers did not return any results from the mock so the called would get null. Fixes issue with PHP 7.2 where calling count() with null fails.
48f7d41
to
147433b
Compare
Rebased to get CI fixes from #167 |
add PHP7.2 to stable10