fix: drop JavaScript function tipsy() in favor of bootstrap tooltip
#610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepDiver1975
force-pushed
the
fix/drop-tipsy
branch
4 times, most recently
from
8843f88
to
a81245e
Compare
phil-davis
approved these changes
Nov 14, 2023
jvillafanez
approved these changes
Nov 14, 2023
| @@ -7,6 +7,4 @@ $(document).ready(function() { | |||
| } | |||
| OC.AppConfig.setValue('customgroups', $(this).attr('name'), value); | |||
| }); | |||
|
|
|||
| $('.section .icon-info').tipsy({gravity: 'w'}); | |||
There was a problem hiding this comment.
I'd expect a $('.....').tooltip() or something similar given the description. I assume this is intended.
There was a problem hiding this comment.
$('.section .icon-info').tooltip() is already called in core - it was a duplicate form the first day
DeepDiver1975
force-pushed
the
fix/drop-tipsy
branch
from
a81245e
to
a80b42e
Compare
DeepDiver1975
force-pushed
the
fix/drop-tipsy
branch
from
a80b42e
to
338d646
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
DeepDiver1975
changed the title
tipsy() in favor of botstrap tooltiptipsy() in favor of bootstrap tooltip
This was referenced Feb 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs owncloud/core#41099
can be released any time - but before 10.14 goes out ....