-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: implement hooks to properly cleanup users upon complete removal #626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
My reproducer is fixed. Also I no longer see any ghost user with avatar (X).
I don't understand why CI fails, the case of removing a user from a custom group works fine for me, with or without this patch.
I also do not understand it, but running the tests locally confirm that test is failing with this PR in place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my suggestion, other than that LGTM.
Co-authored-by: Ilja Neumann <ineumann@owncloud.com>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hooks:register(); is nicer.
Everything works like a charm now.
We are currently missing the hook for removing the user from the
oc_custom_group_member
table when performing the user deletion. I do not see any reason why the user should still be listed in the custom groups view (with an X avatar).This would solve the issue for both "normal" and guest users, as currently when navigating through the group members views a new invitation mail is going to be resent to the guest user so that he/she will regain access to resources he/she should no longer have access to.