fix: implement hooks to properly cleanup users upon complete removal #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnweiger
approved these changes
Apr 10, 2024
|
I also do not understand it, but running the tests locally confirm that test is failing with this PR in place. |
pako81
changed the title
IljaN
reviewed
Apr 11, 2024
IljaN
approved these changes
Apr 11, 2024
Co-authored-by: Ilja Neumann <ineumann@owncloud.com>
|
jnweiger
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently missing the hook for removing the user from the
oc_custom_group_membertable when performing the user deletion. I do not see any reason why the user should still be listed in the custom groups view (with an X avatar).This would solve the issue for both "normal" and guest users, as currently when navigating through the group members views a new invitation mail is going to be resent to the guest user so that he/she will regain access to resources he/she should no longer have access to.