Adding more dispatcher events for the app #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
reviewed
Aug 24, 2017
lib/Service/MembershipHelper.php
Outdated
| @@ -315,6 +315,13 @@ public function notifyUserRoleChange($targetUserId, array $groupInfo, array $mem | |||
| ->setUser($targetUserId) | |||
| ->setLink($link); | |||
| $this->notificationManager->notify($notification); | |||
| if($memberInfo['role'] === 0) { | |||
There was a problem hiding this comment.
Use Roles::BACKEND_ROLE_MEMBER and Roles::BACKEND_ROLE_ADMIN
PVince81
reviewed
Aug 24, 2017
lib/Service/MembershipHelper.php
Outdated
| } elseif ($memberInfo['role'] === 1) { | ||
| $roleName = "Group owner"; | ||
| } | ||
| $event = new GenericEvent(null, ['user' => $targetUserId, 'groupName' => $groupInfo['display_name'], 'role' => $roleName]); |
There was a problem hiding this comment.
let's provide both the numeric role and a roleDisplayName value for the user-friendly version, just in case
Adding more dispatcher events to handle: a) Rename of groups b) Members leaving groups and c) Role change of members in the group Signed-off-by: Sujith H <sharidasan@owncloud.com>
sharidas
force-pushed
the
add-more-events-to-log
branch
from
612de2d
to
497fcec
Compare
|
sharidas
commented
Aug 24, 2017
| } elseif ($memberInfo['role'] === Roles::BACKEND_ROLE_ADMIN) { | ||
| $roleName = "Group owner"; | ||
| } | ||
| $event = new GenericEvent(null, ['user' => $targetUserId, 'groupName' => $groupInfo['display_name'], 'roleNumber' => $memberInfo['role'], 'roleDisaplayName' => $roleName]); |
There was a problem hiding this comment.
Both roleDisplayName as well as numeric roles are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more dispatcher events to handle:
a) Rename of groups
b) Members leaving groups and
c) Role change of members in the group
Signed-off-by: Sujith H sharidasan@owncloud.com