Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: prepare ocis migration guide from 4 to 5 #739

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Feb 29, 2024

Fixes: #736

@kulmann @butonic we still need to

  • add the theme migration and
  • the deprecations.

Backport to 5.0

Copy link
Member

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about TTL config changes that got fixed with owncloud/ocis@8e613bb

But the config var was already introduced in v4, so no change necessary

@butonic
Copy link
Member

butonic commented Mar 1, 2024

Another inconsistency is STORAGE_USERS_FILEMETADATA_CACHE_STORE vs STORAGE_SYSTEM_CACHE_STORE both are used to configure the filemetadata cache of storage-users / storage-system ... 😞

STORAGE_SYSTEM_CACHE_STORE should be STORAGE_SYSTEM_FILEMETADATA_CACHE_STORE

@mmattel
Copy link
Contributor

mmattel commented Mar 1, 2024

I have updated and cleaned up the content.
It is also pushed to staging to see how it is finally rendered.

Copy link
Contributor Author

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added service accounts and deprecations.

modules/ROOT/pages/migration/upgrading_4.0.0_5.0.0.adoc Outdated Show resolved Hide resolved
@micbar micbar marked this pull request as ready for review March 4, 2024 14:31
@micbar
Copy link
Contributor Author

micbar commented Mar 4, 2024

closes #739

@micbar micbar requested a review from ScharfViktor March 4, 2024 15:40
@micbar micbar requested a review from ScharfViktor March 5, 2024 07:50
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side)

@butonic
Copy link
Member

butonic commented Mar 5, 2024

What about #679?

We deprecated ocis storage-users uploads list (it still works) and introduced ocis storage-users uploads sessions

@micbar
Copy link
Contributor Author

micbar commented Mar 5, 2024

@butonic Can you create a separate PR please?

@mmattel
Copy link
Contributor

mmattel commented Mar 6, 2024

We deprecated ocis storage-users uploads list

@micbar @butonic
This is two fold:

  1. The updated command needs to be documented in the storage-users service.
  2. We need to add this change here into the migration docs

I will take care.

UPDATE

  • (2) is done
  • Also got mentioned in the release notes in the deprecation section

@micbar micbar merged commit e703f28 into master Mar 11, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the migration-4-5 branch March 11, 2024 14:53
@micbar micbar mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5.0] Document Upgrade from 4.0 to 5.0
6 participants