Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle focus after folder load #79

Merged
merged 2 commits into from
Aug 5, 2021
Merged

feat: handle focus after folder load #79

merged 2 commits into from
Aug 5, 2021

Conversation

LukasHirt
Copy link
Collaborator

We've added focus management so that the last breadcrumb item will be focus after a folder has been loaded.
By default, this focus management is disabled on the first load when opening the file picker.
To enable it also during the first load, set prop isInitialFocusEnabled to true.

@LukasHirt LukasHirt added the enhancement New feature or request label Aug 3, 2021
@LukasHirt LukasHirt self-assigned this Aug 3, 2021
pascalwengerter
pascalwengerter approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM but I'm not able to test it locally, small nitpick about the changelog item (but not a dealbreaker)

changelog/unreleased/enhancement-focus-mngmt Outdated Show resolved Hide resolved
Update changelog/unreleased/enhancement-focus-mngmt
b1c0f6e 
Co-authored-by: Pascal Wengerter <pwengerter@owncloud.com>
@LukasHirt LukasHirt merged commit bbfda00 into master Aug 5, 2021
@LukasHirt LukasHirt deleted the feat/focus-mngmt branch August 5, 2021 09:39
ownclouders pushed a commit that referenced this pull request Aug 5, 2021
commit bbfda00
d6e9b45 
Merge: 7724dca b1c0f6e
Author: Lukas Hirt <lhirt@owncloud.com>
Date:   Thu Aug 5 11:39:27 2021 +0200

    Merge pull request #79 from owncloud/feat/focus-mngmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@lookacat lookacat Awaiting requested review from lookacat

@kulmann kulmann Awaiting requested review from kulmann kulmann is a code owner

@fschade fschade Awaiting requested review from fschade fschade is a code owner

Assignees

@LukasHirt LukasHirt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasHirt @pascalwengerter