Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fileactions: get rid of deprecate register function, adjust name, displayName and icon #836

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Apr 13, 2021

Description

With this PR we will show a proper name in the file actions menu

Screenshots or screencasts

image

@AlexAndBear AlexAndBear marked this pull request as ready for review April 13, 2021 08:07
@AlexAndBear AlexAndBear requested a review from JammingBen April 13, 2021 08:08
@AlexAndBear AlexAndBear mentioned this pull request Apr 13, 2021
44 tasks
@phil-davis
Copy link
Contributor

@janackermann you need to ask @xoxys or @micbar or someone with enough privs to enable drone again for this repo: https://drone.owncloud.com/owncloud/gallery/settings

@AlexAndBear AlexAndBear force-pushed the update-file-actions branch from 6a2f64e to 9405cb3 Compare April 13, 2021 08:13
@AlexAndBear
Copy link
Author

@phil-davis we reactivated it but ci is broken

@phil-davis
Copy link
Contributor

@phil-davis we reactivated it but ci is broken

The CI .drone.yml and dependencies etc are way out-of-date. I can make a PR to update all that stuff first and get CI green...

@xoxys
Copy link

xoxys commented Apr 13, 2021

Oh wow a repo from the stone age 🙃 Thanks @phil-davis for taking care

@AlexAndBear
Copy link
Author

@micbar said stop it in the first place, to coordinate it, so I am not sure...

@micbar
Copy link

micbar commented Apr 13, 2021

@phil-davis give it a shot, my problem is that this was totally unplanned and was starting to sidetrack a lot of people.

@phil-davis
Copy link
Contributor

@phil-davis give it a shot, my problem is that this was totally unplanned and was starting to sidetrack a lot of people.

I will do the quick cut-paste of CI from another app and see how easily it runs.

@phil-davis
Copy link
Contributor

@janackermann please rebase - #838 has been merged, so we have code-style and regular PHP unit tests running in CI.

@AlexAndBear AlexAndBear force-pushed the update-file-actions branch from 9405cb3 to 9d35fa5 Compare April 13, 2021 09:11
@AlexAndBear
Copy link
Author

Nice one!

@AlexAndBear AlexAndBear merged commit 13143aa into master Apr 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-file-actions branch April 13, 2021 09:13
@jnweiger jnweiger mentioned this pull request Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants