Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review all skipped tests #192

Open
individual-it opened this issue Jan 18, 2024 · 3 comments
Open

review all skipped tests #192

individual-it opened this issue Jan 18, 2024 · 3 comments

Comments

@individual-it
Copy link
Member

individual-it commented Jan 18, 2024

there are still some tests skipped, need to review them and check if they are now fixed in ocis

@nirajacharya2
Copy link
Contributor

updated few tests in #205
one test is still skipped and one is incomplete.
unassigning myself for now

@nirajacharya2 nirajacharya2 removed their assignment Mar 1, 2024
@nirajacharya2
Copy link
Contributor

currently there are 2 tests that are skipped

  1. public function testGetDriveById(): void

    is blocked due to an issue in libre-graph-api
    Create drive return zero quota size  libre-graph-api#149


  2. is skipped because the tested feature is not implemented
    [sharing-ng] blocksDownload link type is not implemented yet ocis#7879

@phil-davis
Copy link
Contributor

I had a quick review of this. The 2 skipped tests are still the same as in the post on 22 April
#192 (comment)

testGetDriveById does some assert checks and then does markTestIncomplete

testCreateLink is skipped for the SharingLinkType::BLOCKS_DOWNLOAD test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants