A11y improvements for IDP service & updated accounts & settings embed…

….go's
owncloud · Jul 16, 2021 · 754a049 · 754a049
1 parent 04e5cfa
commit 754a049
Show file tree

Hide file tree

Showing 6 changed files with 184 additions and 148 deletions.
diff --git a/accounts/pkg/assets/embed.go b/accounts/pkg/assets/embed.go
diff --git a/changelog/unreleased/improve-idp-accessibility b/changelog/unreleased/improve-idp-accessibility
@@ -0,0 +1,7 @@
+Bugfix: Improve IDP Login Accessibility
+
+We have addressed the feedback from the `a11y` audit and improved 
+the IDP login screen accordingly.
+
+https://github.com/owncloud/web/issues/5376
+https://github.com/owncloud/web/issues/5377
diff --git a/idp/pkg/assets/embed.go b/idp/pkg/assets/embed.go
diff --git a/idp/ui/src/components/ResponsiveScreen.js b/idp/ui/src/components/ResponsiveScreen.js
@@ -49,7 +49,7 @@ const ResponsiveScreen = (props) => {
   } = props;
 
   const logo = withoutLogo ? null :
-    <img src={process.env.PUBLIC_URL + '/static/logo.svg'} className="oc-logo" alt="ownCloud"/>;
+    <img src={process.env.PUBLIC_URL + '/static/logo.svg'} className="oc-logo" alt="ownCloud Logo"/>;
 
   const content = loading ? <Loading/> : (withoutPadding ? children : <DialogContent>{children}</DialogContent>);
 

diff --git a/idp/ui/src/containers/Login/Login.js b/idp/ui/src/containers/Login/Login.js
@@ -106,7 +106,7 @@ class Login extends React.PureComponent {
                   id="oc-login-password"
                   {...extraPropsPassword}
               />
-              {hasError && <Typography id="oc-login-error-message" variant="subtitle2" color="error"
+              {hasError && <Typography id="oc-login-error-message" variant="subtitle2" component="label" color="error"
                                        className={classes.message}>{errorMessage}</Typography>}
               <div className={classes.wrapper}>
                 <Button

diff --git a/settings/pkg/assets/embed.go b/settings/pkg/assets/embed.go