Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the LinkUpdated activity in the space context #10085

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Added the LinkUpdated activity in the space context #10085

merged 1 commit into from
Sep 18, 2024

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Sep 17, 2024 •
edited
Loading

Description

Related Issue

Motivation and Context

Added the LinkUpdated activity in the space context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

fschade
fschade reviewed Sep 18, 2024
View reviewed changes
changelog/unreleased/fix-acitivity-update-public-link.md Outdated

Added the LinkUpdated activity in the space context

https://github.com/owncloud/ocis/pull/9856
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.../issues/...

fschade
fschade approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny thing inside the changelog, beside that LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dragonchaser
dragonchaser requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@dragonchaser dragonchaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge yet, we have changes to the same file and i10 adaptions....

dragonchaser
dragonchaser approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@dragonchaser dragonchaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge, the other one needs adaptions to web

@2403905 2403905 merged commit 9c0f51b into owncloud:master Sep 18, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Sep 18, 2024
@2403905
Merge pull request #10085 from 2403905/issue-10012
15b7331 
Added the LinkUpdated activity in the space context
@micbar micbar mentioned this pull request Oct 1, 2024
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonchaser dragonchaser dragonchaser approved these changes

@kobergj kobergj kobergj approved these changes

@fschade fschade fschade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Activities. no activity for public link change (role, expiration date, password)
4 participants
@2403905 @dragonchaser @kobergj @fschade