-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test-only] add test for checking service ready and health #10351
Open
ScharfViktor
wants to merge
3
commits into
master
Choose a base branch
from
healthzCheck
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+289
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
ScharfViktor
requested review from
dragonchaser,
2403905,
fschade and
saw-jan
October 18, 2024 13:57
ScharfViktor
force-pushed
the
healthzCheck
branch
7 times, most recently
from
October 22, 2024 17:39
daaa9fd
to
1976941
Compare
ScharfViktor
requested review from
wkloucek,
micbar,
phil-davis and
individual-it
as code owners
October 22, 2024 18:47
ScharfViktor
force-pushed
the
healthzCheck
branch
from
October 22, 2024 20:59
f8de1a5
to
a38ae28
Compare
saw-jan
reviewed
Oct 23, 2024
tests/acceptance/features/apiCollaboration/serviceAvailabilityCheck.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiAntivirus/serviceAvailabilityCheck.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiAntivirus/serviceAvailabilityCheck.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiCollaboration/serviceAvailabilityCheck.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/serviceAvailability/serviceAvailabilityCheck.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/serviceAvailability/serviceAvailabilityCheck.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/serviceAvailability/serviceAvailabilityCheck.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/serviceAvailability/serviceAvailabilityCheck.feature
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
releated #8783 #10316
I checked
/healthz
and/readyz
of every servicesmy steps:
ocis/bin/ocis nats server
OCIS_INSECURE=true PROXY_ENABLE_BASIC_AUTH=true IDM_CREATE_DEMO_USERS=true OCIS_EXCLUDE_RUN_SERVICES=nats ocis/bin/ocis server
Okay
http://127.0.0.1:9243/healthz
-> okayhttp://127.0.0.1:9243/readyz
- should be 500run nats again
@saw-jan regarding stop and start nats during the test:
let do it in the next PR:
I see two ways: