Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-only] disable Traefik dasboard as default for deployment examples #1380

Merged
merged 4 commits into from
Jan 23, 2021

Conversation

wkloucek
Copy link
Contributor

Description

This PR deactivates the Traefik dasboards of our deployment examples as default. Users may still activate it by setting TRAEFIK_DASHBOARD to true in the configuration file.

Related Issue

  • Fixes <issue_link>

Motivation and Context

This simplifies the DNS setup for people because if you don't activate the dashboard you will need one DNS record less. In the example of the oCIS with Traefik example users will only need one DNS record instead of two (assuming they are not using wildcard entries)

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jan 21, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek requested a review from C0rby January 21, 2021 18:13
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@wkloucek wkloucek merged commit 9e68275 into master Jan 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the disable_traefik_dashboard_for_deployment_examples branch January 23, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants