Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reva to latest master #1588

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Update reva to latest master #1588

merged 1 commit into from
Feb 12, 2021

Conversation

IljaN
Copy link
Member

@IljaN IljaN commented Feb 2, 2021

@update-docs
Copy link

update-docs bot commented Feb 2, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@C0rby
Copy link
Contributor

C0rby commented Feb 11, 2021

I can't reproduce the first trashbin failure but the second is caused by a frontend bug...
It seems like folders with a dot in the name are displayed like files in the trashbin.

@C0rby
Copy link
Contributor

C0rby commented Feb 11, 2021

Hm or it is a trashbin api issue because on https://ocis.ocis-traefik.latest.owncloud.works it works flawlessly.

@C0rby
Copy link
Contributor

C0rby commented Feb 11, 2021

Found the issue:

<d:prop>
     <oc:trashbin-original-filename>test.txt</oc:trashbin-original-filename>
     <oc:trashbin-original-location>test.txt</oc:trashbin-original-location>
     <oc:trashbin-delete-datetime>Thu, 11 Feb 2021 20:15:12 +0000</oc:trashbin-delete-datetime>
     <d:resourcetype>&lt;d:collection/&gt;</d:resourcetype>
</d:prop>

If you look closely you can see that some characters, which should not get encoded, get encoded...
hint resource type hint

@C0rby
Copy link
Contributor

C0rby commented Feb 11, 2021

Here is the fix for ^ cs3org/reva#1472

@C0rby
Copy link
Contributor

C0rby commented Feb 12, 2021

For the last failure we would need to update the webui tests....
The webui has changed quite a bit so first add update the webui commit and then update the test in https://github.com/owncloud/web/blob/541116e2832faaff96dd9098a45968a3c4d1c7de/tests/acceptance/features/webUITrashbinFilesFolders/trashbinFilesFolders.feature#L29

@phil-davis
Copy link
Contributor

I bumped the web commit id yesterday in PR #1622 and "it all broke" (tm) https://drone.owncloud.com/owncloud/ocis/3338/41/7

I did not get back to looking at it today.

We need to regularly pull the latest web into OCIS, otherwise "stuff happens" and it gets difficult to remember what environment stuff has to be adjusted.

@C0rby
Copy link
Contributor

C0rby commented Feb 12, 2021

I found a commit from @IljaN from 7 days ago. I now updated the commit id to that. Let's see if that works.
But I agree we need to update web more often.

@IljaN IljaN force-pushed the update-reva-to-master branch 2 times, most recently from 466ed0b to e329742 Compare February 12, 2021 14:04
@IljaN IljaN assigned IljaN and C0rby Feb 12, 2021
@IljaN IljaN marked this pull request as ready for review February 12, 2021 14:06
Co-authored-by: David Christofas <dchristofas@owncloud.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@IljaN IljaN merged commit 0c6c18f into master Feb 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-reva-to-master branch February 12, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants