Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Change storage driver from owncloud to ocis for webUITests pipeline #1990

Merged
merged 2 commits into from
May 4, 2021
Merged

[Tests-Only] Change storage driver from owncloud to ocis for webUITests pipeline #1990

merged 2 commits into from
May 4, 2021

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Apr 29, 2021

Description

Changes storage driver from owncloud to ocis for webUI tests pipeline

Related Issue

How Has This Been Tested?

  • test environment:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Apr 29, 2021
@phil-davis
Copy link
Contributor

What should we do about https://github.com/owncloud/ocis/blob/master/tests/acceptance/expected-failures-webUI-on-OWNCLOUD-storage.md ?

If we are not running CI any more with OWNCLOUD storage, then the listof scenarios in there will get out-of-date.

Do we delete it? Or?

@saw-jan
Copy link
Member Author

saw-jan commented Apr 30, 2021

What should we do about https://github.com/owncloud/ocis/blob/master/tests/acceptance/expected-failures-webUI-on-OWNCLOUD-storage.md ?

If we are not running CI any more with OWNCLOUD storage, then the listof scenarios in there will get out-of-date.

Do we delete it? Or?

we can delete it if we won't run tests against owncloud storage in upcoming days. Or other thoughts?
@individual-it @phil-davis

@individual-it
Copy link
Member

yes, I would propose to delete that file

@phil-davis phil-davis self-requested a review April 30, 2021 04:59
@saw-jan saw-jan force-pushed the change-storage-driver branch 4 times, most recently from a736732 to 7319f6d Compare April 30, 2021 06:43
@phil-davis phil-davis self-requested a review April 30, 2021 06:46
kiranparajuli589
kiranparajuli589 reviewed Apr 30, 2021
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than the exisiting comments..lgtm 👍🏼

@saw-jan saw-jan force-pushed the change-storage-driver branch 2 times, most recently from 6afde3d to 456f595 Compare April 30, 2021 11:23
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/4808/69/7 had a webUI test fail.
"Unexpected failure or crash of the nightwatch test run"
I restarted CI.

jasson99
jasson99 reviewed Apr 30, 2021
View reviewed changes
Copy link
Contributor

@jasson99 jasson99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis
Copy link
Contributor

phil-davis commented Apr 30, 2021 •
edited
Loading

https://drone.owncloud.com/owncloud/ocis/4813/69/7
"Unexpected failure or crash of the nightwatch test run"

That is happening every time I restart, but only for webUITrashbinRestore suite.

Some webUITrashbinRestore scenarios have been removed from the expected-failures file. But that does not explain why it reports a nightwatch general failure.

What is going on?

@saw-jan
Copy link
Member Author

saw-jan commented Apr 30, 2021 •
edited
Loading

That one will always fail. I think the problematic scenario is trashbinRestore.feature:260 and it is tagged with issue https://github.com/owncloud/ocis/issues/1128
It happens when ocis storage. previously with owncloud storage it was working fine (I mean, was failing fine)

the error in CI is:
TypeError: trashData.map is not a function
I think trashData is getting value other that type array

@phil-davis
Copy link
Contributor

We need to think what to do. It is strange that we can make a crash like this in the test scripts. There is no way to add this to expected-failures! So next week we need to sort out how to fix it.

@saw-jan
Copy link
Member Author

saw-jan commented May 4, 2021 •
edited
Loading

We need to think what to do. It is strange that we can make a crash like this in the test scripts. There is no way to add this to expected-failures! So next week we need to sort out how to fix it.

Should be fixed by PR owncloud/web#5061
POC: https://drone.owncloud.com/owncloud/ocis/4856/19/7

@saw-jan saw-jan force-pushed the change-storage-driver branch 3 times, most recently from 060fe0d to 46fc8f5 Compare May 4, 2021 08:36
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan requested a review from phil-davis May 4, 2021 09:42
@phil-davis phil-davis merged commit f9afcbc into master May 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the change-storage-driver branch May 4, 2021 09:49
ownclouders pushed a commit that referenced this pull request May 4, 2021
@phil-davis
commit f9afcbc
9861f03 
Merge: 896c46f e78c93e
Author: Phil Davis <phil@jankaritech.com>
Date:   Tue May 4 15:34:02 2021 +0545

    Merge pull request #1990 from owncloud/change-storage-driver

    [Tests-Only] Change storage driver from `owncloud` to `ocis` for webUITests pipeline
@phil-davis phil-davis mentioned this pull request May 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@jasson99 jasson99 jasson99 left review comments

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@swoichha swoichha Awaiting requested review from swoichha

@Talank Talank Awaiting requested review from Talank

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change storage provider in web tests to ocis storage
5 participants
@saw-jan @phil-davis @individual-it @kiranparajuli589 @jasson99