Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only]Adjust expected failures file #2159

Merged
merged 1 commit into from
Jun 14, 2021
Merged

[Tests-Only]Adjust expected failures file #2159

merged 1 commit into from
Jun 14, 2021

Conversation

jasson99
Copy link
Contributor

Description

This PR adjust expected failures file after the adjustments of notToImplementOnOcis tags for the old public webdav API tests.

Related Issue

#2078

How Has This Been Tested?

  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@jasson99 jasson99 mentioned this pull request Jun 10, 2021
Merged
11 tasks
@jasson99 jasson99 self-assigned this Jun 10, 2021
@jasson99 jasson99 force-pushed the fixexpectedFailures branch 3 times, most recently from c40b03b to 07d0958 Compare June 11, 2021 08:28
@jasson99 jasson99 requested a review from dpakach June 11, 2021 08:30
dpakach
dpakach reviewed Jun 11, 2021
View reviewed changes
Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
a lot of lines got deleted from the expected failure file..... great work 👍🏼

@dpakach dpakach requested a review from phil-davis June 11, 2021 10:35
dpakach
dpakach suggested changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just requesting changes to make sure this doesn't gets merged accidently

.drone.env Outdated
CORE_COMMITID=b587826832245d9c5f72ab2a9d831b1be6b66210
CORE_BRANCH=master
CORE_COMMITID=
CORE_BRANCH=dontRunOldPublicWebdavInOcis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note needs this to be changed back to master after owncloud/core#38825 (review) this gets merged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done now.

@jasson99 jasson99 requested a review from dpakach June 14, 2021 07:33
phil-davis
phil-davis approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes

@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jasson99 jasson99 mentioned this pull request Jun 14, 2021
Closed
3 tasks
@phil-davis phil-davis merged commit 06570ae into master Jun 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the fixexpectedFailures branch June 14, 2021 09:03
@phil-davis phil-davis mentioned this pull request Jun 14, 2021
Merged
9 tasks
ownclouders pushed a commit that referenced this pull request Jun 14, 2021
@phil-davis
commit 06570ae
86ac2fd 
Merge: 8e64bf5 b9f7d20
Author: Phil Davis <phil@jankaritech.com>
Date:   Mon Jun 14 14:48:27 2021 +0545

    Merge pull request #2159 from owncloud/fixexpectedFailures

    [Tests-Only]Adjust expected failures file
@Talank Talank mentioned this pull request Jun 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@dpakach dpakach dpakach approved these changes

Assignees

@jasson99 jasson99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasson99 @phil-davis @dpakach