Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] update reva to 756bdced1d22 #2385

Merged
merged 1 commit into from
Aug 12, 2021
Merged

[full-ci] update reva to 756bdced1d22 #2385

merged 1 commit into from
Aug 12, 2021

Conversation

butonic
Copy link
Member

@butonic butonic commented Aug 11, 2021

Update REVA from v1.11.1-0.20210809134415-3fe79c870fb5 to v1.11.1-0.20210812105259-756bdced1d22

The change moves Token and User related Context functions and headers to the new github.com/cs3org/reva/pkg/ctx package.

@butonic butonic changed the title update reva to ec4099da [full-ci] update reva to ec4099da Aug 11, 2021
@butonic butonic force-pushed the reva-update-ec4099da branch 3 times, most recently from 4ce0309 to 7411806 Compare August 11, 2021 20:55
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/6333/62/4

1.16: Pulling from owncloudci/golang
Digest: sha256:7e49ef6bfe608e5ebe451f8625ad99149206bc5fd605afbbcb22012b3e437f19
Status: Image is up to date for owncloudci/golang:1.16
+ make -C ocis release-windows
make: Entering directory '/drone/src/ocis'
Makefile:23: warning: overriding recipe for target 'config-docs-generate'
../.make/docs.mk:3: warning: ignoring old recipe for target 'config-docs-generate'
(re)installing /go/bin/gox-v1.0.1
go: downloading github.com/mitchellh/gox v1.0.1
go: downloading github.com/hashicorp/go-version v1.0.0
go: downloading github.com/mitchellh/iochan v1.0.0
mkdir -p dist/binaries dist/release
/go/bin/gox-v1.0.1 -tags 'netgo ' -ldflags '-extldflags "-static" -X google.golang.org/protobuf/reflect/protoregistry.conflictPolicy=warn -s -w -X "github.com/owncloud/ocis/ocis/pkg/version.String=76b34f33" -X "github.com/owncloud/ocis/ocis/pkg/version.Date=20210811"' -os 'windows' -arch 'amd64' -output 'dist/binaries/ocis-testing-{{.OS}}-{{.Arch}}' ./cmd/ocis
Number of parallel builds: 15

-->   windows/amd64: github.com/owncloud/ocis/ocis/cmd/ocis

1 errors occurred:
--> windows/amd64 error: exit status 2
Stderr: # github.com/cs3org/reva/pkg/storage/fs/owncloudsql
/go/pkg/mod/github.com/cs3org/reva@v1.11.1-0.20210811142901-ec4099da830e/pkg/storage/fs/owncloudsql/owncloudsql_windows.go:62:18: undefined: windows
/go/pkg/mod/github.com/cs3org/reva@v1.11.1-0.20210811142901-ec4099da830e/pkg/storage/fs/owncloudsql/owncloudsql_windows.go:66:8: undefined: windows
# github.com/cs3org/reva/pkg/storage/fs/owncloud
/go/pkg/mod/github.com/cs3org/reva@v1.11.1-0.20210811142901-ec4099da830e/pkg/storage/fs/owncloud/owncloud_windows.go:62:18: undefined: windows
/go/pkg/mod/github.com/cs3org/reva@v1.11.1-0.20210811142901-ec4099da830e/pkg/storage/fs/owncloud/owncloud_windows.go:66:8: undefined: windows

make: *** [../.make/release.mk:21: release-windows] Error 1
make: Leaving directory '/drone/src/ocis'

All tests passed, and then M$ gives this error.

@butonic
Copy link
Member Author

butonic commented Aug 12, 2021

😞 my bad, fixed with cs3org/reva#1987

@wkloucek
Copy link
Contributor

@butonic Windows builds are failing 🤔

/go/pkg/mod/github.com/cs3org/reva@v1.11.1-0.20210811142901-ec4099da830e/pkg/storage/fs/owncloudsql/owncloudsql_windows.go:66:8: undefined: windows
26

@butonic butonic changed the title [full-ci] update reva to ec4099da [full-ci] update reva to 756bdced1d22 Aug 12, 2021
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

31.7% 31.7% Coverage
4.5% 4.5% Duplication

Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@C0rby C0rby merged commit 2f4d065 into master Aug 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the reva-update-ec4099da branch August 12, 2021 12:08
ownclouders pushed a commit that referenced this pull request Aug 12, 2021
Merge: 6c7bbd9 55aacde
Author: David Christofas <dchristofas@owncloud.com>
Date:   Thu Aug 12 14:08:17 2021 +0200

    Merge pull request #2385 from owncloud/reva-update-ec4099da

    [full-ci] update reva to 756bdce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants