Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix naming of the user- and groupprovider services #2388

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Fix naming of the user- and groupprovider services #2388

merged 1 commit into from
Aug 13, 2021

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Aug 12, 2021

The services ared called "storage-userprovider" and "-groupprovider".
The 'ocis help' output was missleading. This also renames the structs
accordingly.

@rhafer rhafer requested a review from refs August 12, 2021 13:12
@rhafer rhafer self-assigned this Aug 12, 2021
@update-docs
Copy link

update-docs bot commented Aug 12, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@rhafer
Fix naming of the user- and groupprovider services
8817e2b 
The services ared called "storage-userprovider" and "-groupprovider".
The 'ocis help' output was missleading. This also renames the structs
accordingly.
@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

13.1% 13.1% Coverage
3.2% 3.2% Duplication

@butonic
Copy link
Member

butonic commented Aug 12, 2021

I was double checking the pkg/flagset to see if any env vars might need renaming... could you fix

  1. STORAGE_SHARING_DEBUG_ADDR -> STORAGE_USERPROVIDER_DEBUG_ADDR in

    ocis/storage/pkg/flagset/users.go

    Line 18 in 8817e2b

    EnvVars: []string{"STORAGE_SHARING_DEBUG_ADDR"},

butonic
butonic requested changes Aug 12, 2021
View reviewed changes
Copy link
Member

@butonic butonic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and add a changelog please ... it seems CI no longer requires it ... but in this case the command name change is visible ...

@butonic butonic merged commit 6485391 into owncloud:master Aug 13, 2021
ownclouders pushed a commit that referenced this pull request Aug 13, 2021
@butonic
commit 6485391
37e8db7 
Merge: fc97f52 8817e2b
Author: Jörn Friedrich Dreyer <jfd@butonic.de>
Date:   Fri Aug 13 15:04:09 2021 +0200

    Merge pull request #2388 from rhafer/cleanup

    Fix naming of the user- and groupprovider services
@rhafer rhafer deleted the cleanup branch August 16, 2021 12:52
@rhafer
Copy link
Contributor Author

rhafer commented Aug 16, 2021

and add a changelog please ... it seems CI no longer requires it ... but in this case the command name change is visible ...

Done -> #2407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@refs refs Awaiting requested review from refs

Assignees

@rhafer rhafer

Labels
Type:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhafer @butonic