Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage Spaces Attributes #2588

Merged
merged 8 commits into from
Oct 8, 2021
Merged

Manage Spaces Attributes #2588

merged 8 commits into from
Oct 8, 2021

Conversation

refs
Copy link
Member

@refs refs commented Oct 7, 2021 •
edited
Loading

TODO

  • Update Reva's FS interface with UpdateStorageSpace see Extend fs.FS interface with UpdateStorageSpace cs3org/reva#2141)
    • Use a FieldMask to update attributes? This is a high work load but future proof. At the moment we are only updating the space name through this API.
    • Updating an image and description must make use of the webdav endpoints from the space.
  • Documentation.

Easy copy-paste commands:

  • update the name property of a drive:
    curl -k -X PATCH 'https://localhost:9200/graph/v1.0/Drive("1284d238-aa92-42ce-bdc4-0b0000009157!07c26b3a-9944-4f2b-ab33-b0b326fc7570")' -d '{"name":"42"}' -u admin:admin -v

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Oct 7, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@refs
Copy link
Member Author

refs commented Oct 7, 2021 •
edited
Loading

Link dump:

@refs refs self-assigned this Oct 7, 2021
@refs refs marked this pull request as draft October 7, 2021 11:17
@refs refs requested review from butonic and micbar October 8, 2021 12:08
@refs refs marked this pull request as ready for review October 8, 2021 12:12
@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

micbar
micbar reviewed Oct 8, 2021
View reviewed changes
graph/pkg/service/v0/drives.go
StorageId: storageID,
OpaqueId: opaqueID,
},
Name: *drive.Name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add quota? Setting quota on create already works.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not part of the acceptance criteria

micbar
micbar approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@refs refs merged commit 984d928 into master Oct 8, 2021
@refs refs deleted the manage-spaces branch October 8, 2021 14:27
ownclouders pushed a commit that referenced this pull request Oct 8, 2021
@refs
commit 984d928
024e08b 
Merge: d8b0b60 052b25e
Author: Alex Unger <6905948+refs@users.noreply.github.com>
Date:   Fri Oct 8 16:27:18 2021 +0200

    Merge pull request #2588 from owncloud/manage-spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@butonic butonic Awaiting requested review from butonic

Assignees

@refs refs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refs @micbar