Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deployment examples] fix CodiMD save hook in WOPI example #2600

Merged
merged 1 commit into from
Oct 8, 2021
Merged

[deployment examples] fix CodiMD save hook in WOPI example #2600

merged 1 commit into from
Oct 8, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Oct 8, 2021

Description

Fixes the CodiMD save hook, so that files are actually saved.

Related Issue

Motivation and Context

How Has This Been Tested?

  • Edit markdown with CodiMD and download it afterwards -> content will be saved

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Oct 8, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek requested review from C0rby and kulmann October 8, 2021 17:55
@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kulmann
kulmann approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann kulmann merged commit f63fe92 into master Oct 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix_codimd_save_hook branch October 8, 2021 19:31
ownclouders pushed a commit that referenced this pull request Oct 8, 2021
@kulmann
commit f63fe92
6663123 
Merge: 984d928 74bb7bc
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Fri Oct 8 21:31:37 2021 +0200

    Merge pull request #2600 from owncloud/fix_codimd_save_hook

    [deployment examples] fix CodiMD save hook in WOPI example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@C0rby C0rby Awaiting requested review from C0rby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @kulmann