Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first prototype of a CS3 permissions service #2852

Merged
merged 4 commits into from
Jan 28, 2022
Merged

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Dec 8, 2021

This PR is part of the introduction of the permissions API to the CS3 APIs.
It implements the new permissions API.

@update-docs
Copy link

update-docs bot commented Dec 8, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Jan 27, 2022

💥 Acceptance test Web-Tests-ocis-smoke-ocis-storage-1 failed. Further test are cancelled...

David Christofas added 3 commits January 27, 2022 16:56
When deleting a user using the OCS api we want to delete the users home
space. Now to completely delete a space you need to send two requests.
First to 'disable' a space and a second one to really purge it.
This commit introduces this second purge request.
Furthermore the OCS api now also deletes all spaces owned by the user
not only the home space. This is needed since some tests create project
spaces and then lookup the space by name. When doing multiple runs
though the tests will find several spaces with the same name and will
sometimes choose the wrong one which leads to test failures.

The whole test tear down should be changed to correctly clean up the
test setup.
@C0rby
Copy link
Contributor Author

C0rby commented Jan 28, 2022

temporary hack for deleting a user

When deleting a user using the OCS api we want to delete the users home
space. Now to completely delete a space you need to send two requests.
First to 'disable' a space and a second one to really purge it.
This commit introduces this second purge request.
Furthermore the OCS api now also deletes all spaces owned by the user
not only the home space. This is needed since some tests create project
spaces and then lookup the space by name. When doing multiple runs
the tests will find several spaces with the same name and will sometimes
choose the wrong one which leads to test failures.

The whole test tear down should be changed to correctly clean up the
test setup.

@C0rby C0rby marked this pull request as ready for review January 28, 2022 09:56
@C0rby C0rby requested review from butonic, kobergj and micbar and removed request for kulmann and pascalwengerter January 28, 2022 09:56
settings/pkg/server/grpc/server.go Show resolved Hide resolved
settings/pkg/server/grpc/server.go Outdated Show resolved Hide resolved
settings/pkg/store/filesystem/permissions.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
15.2% 15.2% Duplication

@C0rby C0rby merged commit 84f63c3 into master Jan 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the cs3-permissions-service branch January 28, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants