Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] getPersonalSpaceIdForUser from webdav propfind #3077

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 1, 2022

Bump core commit id to include core PR owncloud/core#39751

That does not behave any different here in oCIS. The extra core test code in that branch should only be actually used when running on reva.

I standardized the indent of lines in expected-failures. I chose to keep the indent that is currently most used, to give the less number of lines changed. Having the indent the same everywhere makes it easier when copying lines between expected-failures files here and in reva etc.

Issue owncloud/QA#715

@phil-davis phil-davis self-assigned this Feb 1, 2022
@phil-davis phil-davis force-pushed the getPersonalSpaceIdForUser-from-webdav-propfind branch 2 times, most recently from 91fa264 to 12062bd Compare February 3, 2022 14:55
@phil-davis
Copy link
Contributor Author

good - that does not break the test running on oCIS.

@phil-davis phil-davis force-pushed the getPersonalSpaceIdForUser-from-webdav-propfind branch from 7fe2fec to 11f6e37 Compare February 7, 2022 04:09
@phil-davis phil-davis marked this pull request as ready for review February 7, 2022 04:11
@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@phil-davis phil-davis merged commit 1310b57 into master Feb 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the getPersonalSpaceIdForUser-from-webdav-propfind branch February 7, 2022 05:32
ownclouders pushed a commit that referenced this pull request Feb 7, 2022
Merge: 8811dd3 11f6e37
Author: Phil Davis <phil@jankaritech.com>
Date:   Mon Feb 7 11:17:28 2022 +0545

    Merge pull request #3077 from owncloud/getPersonalSpaceIdForUser-from-webdav-propfind

    [tests-only] [full-ci] getPersonalSpaceIdForUser from webdav propfind
ownclouders pushed a commit that referenced this pull request Feb 8, 2022
Merge: 8811dd3 11f6e37
Author: Phil Davis <phil@jankaritech.com>
Date:   Mon Feb 7 11:17:28 2022 +0545

    Merge pull request #3077 from owncloud/getPersonalSpaceIdForUser-from-webdav-propfind

    [tests-only] [full-ci] getPersonalSpaceIdForUser from webdav propfind
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants