-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set missing env vars #392
set missing env vars #392
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitly correct in this docker-compose.yml.
@felixboehm please double-check, if needed elsewhere (compose-playground?) too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both URLs are supposed to be reachable from outside, so the port 9200 should only be on the localhost fallback, not on the OCIS_DOMAIN
fine if it works. I don’t understand these configs... we need to update in
|
ee7884c
to
44fba8e
Compare
REVA_FRONTEND_URL and REVA_DATAGATEWAY_URL need to be set to the OCIS_DOMAIN so upload is not using localhost ;-) cc @jnweiger Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
44fba8e
to
933a5be
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> arm build failures unrelated
REVA_FRONTEND_URL and REVA_DATAGATEWAY_URL need to be set to the OCIS_DOMAIN so upload is not using localhost ;-)
cc @jnweiger