Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version info #3953

Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix version info #3953

merged 1 commit into from
Jun 13, 2022

Conversation

wkloucek
Copy link
Contributor

Description

Bugfix: Fix version info

We've fixed the version info that is displayed when you run:

  • ocis version
  • ocis <extension name> version

Since #2918, these commands returned an empty version only.

Reproduce the bug:

  • curl https://download.owncloud.com/ocis/ocis/testing/2.0.0-beta.3/ocis-2.0.0-beta.3-linux-amd64 --output ocis
  • ocis server
  • ocis version yields:
Version: 
Compiled: 2022-06-13 00:00:00 +0000 UTC

+---------+----------------------+--------------------------------------------------------------------------+
| Version |       Address        |                                    Id                                    |
+---------+----------------------+--------------------------------------------------------------------------+
|         | 127.0.0.1:9130       | com.owncloud.web.idp-c9dc2121-d97f-42dd-86e0-0a1b0190f080                |
|         | 127.0.0.1:9150       | com.owncloud.api.sharing-d3b71fc9-15be-48b1-8b44-1048075a76a8            |
|         | 127.0.0.1:9120       | com.owncloud.graph.graph-c9dc2121-d97f-42dd-86e0-0a1b0190f080            |
|         | 127.0.0.1:9164       | com.owncloud.api.app-provider-aa258873-7f88-4122-9c21-7e62f6a2ee6e       |
|         | 192.168.178.140:9200 | com.owncloud.web.proxy-c9dc2121-d97f-42dd-86e0-0a1b0190f080              |
|         | 127.0.0.1:9144       | com.owncloud.api.users-389915d9-591e-4eb8-aec2-acb81b2866c2              |
|         | 127.0.0.1:9135       | com.owncloud.web.graph-explorer-c9dc2121-d97f-42dd-86e0-0a1b0190f080     |
|         | 127.0.0.1:9148       | com.owncloud.api.auth-bearer-7381c248-5baa-4e40-9875-59d7abfd36e5        |
|         | 127.0.0.1:9115       | com.owncloud.web.webdav-c9dc2121-d97f-42dd-86e0-0a1b0190f080             |
|         | 127.0.0.1:9154       | com.owncloud.api.storage-shares-8150f39a-4d28-43b3-8a22-2e4498ec3595     |
|         | 127.0.0.1:9242       | com.owncloud.api.app-registry-b8c98eac-18e9-428a-b1dd-74baa97034e9       |
|         | 127.0.0.1:9220       | com.owncloud.api.search-c9dc2121-d97f-42dd-86e0-0a1b0190f080             |
|         | 127.0.0.1:9166       | com.owncloud.api.auth-machine-02746d6e-37c1-4b0a-8c8e-8e80277e7e40       |
|         | 127.0.0.1:9215       | com.owncloud.api.storage-system-0d9c5616-3400-4f0b-b0ac-c9bf2acba3a2     |
|         | 127.0.0.1:9186       | com.owncloud.web.thumbnails-c9dc2121-d97f-42dd-86e0-0a1b0190f080         |
|         | 127.0.0.1:9216       | com.owncloud.web.storage-system-777c42b5-7ec4-4181-b98b-b5f427d0f4a1     |
|         | 127.0.0.1:9100       | com.owncloud.web.web-c9dc2121-d97f-42dd-86e0-0a1b0190f080                |
|         | 127.0.0.1:9142       | com.owncloud.api.gateway-629227eb-c9c3-4fc5-901e-e376004e739a            |
|         | 127.0.0.1:9185       | com.owncloud.api.thumbnails-c9dc2121-d97f-42dd-86e0-0a1b0190f080         |
|         | 127.0.0.1:9190       | com.owncloud.web.settings-c9dc2121-d97f-42dd-86e0-0a1b0190f080           |
|         | 127.0.0.1:9160       | com.owncloud.api.groups-099b610b-09c6-440d-adec-fb903ef463d4             |
|         | 127.0.0.1:9157       | com.owncloud.api.storage-users-b689957c-12da-4a48-a2f2-208d05b86f11      |
|         | 127.0.0.1:9110       | com.owncloud.web.ocs-c9dc2121-d97f-42dd-86e0-0a1b0190f080                |
|         | 127.0.0.1:9146       | com.owncloud.api.auth-basic-37a4c8f7-e5a7-4602-af6c-2a096686a45b         |
|         | 127.0.0.1:9191       | com.owncloud.api.settings-c9dc2121-d97f-42dd-86e0-0a1b0190f080           |
|         | 127.0.0.1:9140       | com.owncloud.web.frontend-355ef797-1425-4a42-b0d1-5e03b39fd29d           |
| 10.11.0 | 127.0.0.1:32983      | com.owncloud.web.ocdav-c9dc2121-d97f-42dd-86e0-0a1b0190f080              |
|         | 127.0.0.1:9178       | com.owncloud.api.storage-publiclink-2ce40b1c-8e10-4287-9f19-6ebfdd27f172 |
|         | 127.0.0.1:9460       | com.owncloud.api.store-c9dc2121-d97f-42dd-86e0-0a1b0190f080              |
+---------+----------------------+--------------------------------------------------------------------------+

Related Issue

Motivation and Context

How Has This Been Tested?

  • see above

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jun 13, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek requested review from C0rby, butonic, dragonchaser, kobergj, micbar and rhafer and removed request for kulmann and pascalwengerter June 13, 2022 08:44
@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
77.5% 77.5% Duplication

@wkloucek wkloucek merged commit 9b01e73 into owncloud:master Jun 13, 2022
@wkloucek wkloucek deleted the fix-version-info branch June 13, 2022 09:13
ownclouders pushed a commit that referenced this pull request Jun 13, 2022
Merge: 90b15e0 68a6f43
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Mon Jun 13 11:13:23 2022 +0200

    Merge pull request #3953 from wkloucek/fix-version-info

    fix version info
@micbar micbar mentioned this pull request Jun 22, 2022
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants