Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Make storage users mount ids unique by default #5091

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Bugfix: Make storage users mount ids unique by default #5091

merged 1 commit into from
Nov 25, 2022

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Nov 21, 2022 •
edited
Loading

Description

The mount ID of the storage users provider needs to be unique by default. We made this value configurable and added it to ocis init to be sure that we have a random uuid v4. This is important for federated instances.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar micbar force-pushed the configure-providerID branch 2 times, most recently from 68b0aaa to 0176ee7 Compare November 21, 2022 16:53
@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
12.2% 12.2% Duplication

@butonic
Copy link
Member

butonic commented Nov 25, 2022

starting an existing instance fails with an error message that explains what to do. we need to break this now so we dont have to break instances later.

@butonic butonic merged commit 7e6b57e into master Nov 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the configure-providerID branch November 25, 2022 12:47
ownclouders pushed a commit that referenced this pull request Nov 25, 2022
@micbar
commit 7e6b57e
affe7c4 
Author: Michael Barz <mbarz@owncloud.com>
Date:   Fri Nov 25 13:47:41 2022 +0100

    make storage users mount id configurable (#5091)
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
@ScharfViktor ScharfViktor mentioned this pull request Nov 28, 2022
Closed
49 tasks
@ScharfViktor
Copy link
Contributor

I tested it:

  • after init command we have storage_users_mount_id: 7fa81a2a-b94b-4b71-ac7d-bb30b3fb61f3 and mount_id: 7fa81a2a-b94b-4b71-ac7d-bb30b3fb61f3 in the ocis.yaml.

My questions:

  • should we put info to the doc?
  • GATEWAY_STORAGE_USERS_MOUNT_ID and STORAGE_USERS_MOUNT_ID are configurable? Can I generate UUID and start init command with envs GATEWAY_STORAGE_USERS_MOUNT_ID=uuid1 and STORAGE_USERS_MOUNT_ID=uuid2 ? Does not work for me: ocis.yaml contains random uuid, storage_users_mount_id and mount_id are same value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek left review comments

@butonic butonic butonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage uuids are not randomized with init
4 participants
@micbar @butonic @ScharfViktor @wkloucek