Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nodejs dependencies to license tarball #5126

Merged
merged 1 commit into from
Nov 25, 2022
Merged

add nodejs dependencies to license tarball #5126

merged 1 commit into from
Nov 25, 2022

Conversation

wkloucek
Copy link
Contributor

Description

adds nodejs dependencies to the license tarball

Related Issue

Motivation and Context

have all the licenses in one place

How Has This Been Tested?

  • build the license tarball locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Nov 25, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek requested a review from micbar November 25, 2022 08:38
@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek requested review from dragotin and dschmidt and removed request for lookacat November 25, 2022 08:44
dschmidt
dschmidt approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works ... looks good codewise.

How do we notice if it breaks (again)?

@wkloucek wkloucek merged commit 7f68049 into owncloud:master Nov 25, 2022
@wkloucek wkloucek deleted the fix-license-tarball branch November 25, 2022 10:41
ownclouders pushed a commit that referenced this pull request Nov 25, 2022
@wkloucek
commit 7f68049
bb86ad0 
Merge: 11bed1d d3a17bd
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Fri Nov 25 11:41:30 2022 +0100

    Merge pull request #5126 from wkloucek/fix-license-tarball

    add nodejs dependencies to license tarball
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt approved these changes

@kulmann kulmann Awaiting requested review from kulmann kulmann is a code owner

@micbar micbar Awaiting requested review from micbar

@dragotin dragotin Awaiting requested review from dragotin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

license report does not include Web / Nodejs licenses
2 participants
@wkloucek @dschmidt