Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Api tests for deleting the expiration date of a space #5606

Merged
merged 1 commit into from
Feb 22, 2023
Merged

[tests-only][full-ci]Api tests for deleting the expiration date of a space #5606

merged 1 commit into from
Feb 22, 2023

Conversation

SwikritiT
Copy link
Contributor

Description

This PR adds tests to remove the expiration date from a space share in user and group space share

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI
  • local

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@SwikritiT SwikritiT self-assigned this Feb 21, 2023
@SwikritiT SwikritiT mentioned this pull request Feb 21, 2023
Closed
24 tasks
@SwikritiT SwikritiT force-pushed the add-tests-for-delete-expiration-spaces branch from 3dc0cdc to ef49a4a Compare February 22, 2023 03:43
@SwikritiT SwikritiT marked this pull request as ready for review February 22, 2023 03:43
@SwikritiT SwikritiT force-pushed the add-tests-for-delete-expiration-spaces branch from ef49a4a to c1d4f3c Compare February 22, 2023 03:44
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

saw-jan
saw-jan reviewed Feb 22, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SagarGi
SagarGi reviewed Feb 22, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SwikritiT SwikritiT merged commit 0087770 into master Feb 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-tests-for-delete-expiration-spaces branch February 22, 2023 11:05
ownclouders pushed a commit that referenced this pull request Feb 22, 2023
@SwikritiT
commit 0087770
ac3a92e 
Author: Swikriti Tripathi <41103328+SwikritiT@users.noreply.github.com>
Date:   Wed Feb 22 16:50:38 2023 +0545

    Api tests for deleting  the expiration date of a space (#5606)
saw-jan pushed a commit that referenced this pull request Feb 28, 2023
@SwikritiT @saw-jan
Api tests for deleting the expiration date of a space (#5606)
090e708
@saw-jan saw-jan mentioned this pull request Feb 28, 2023
Merged
9 tasks
grgprarup pushed a commit that referenced this pull request Mar 2, 2023
@SwikritiT @grgprarup
Api tests for deleting the expiration date of a space (#5606)
dfb64e9
grgprarup pushed a commit that referenced this pull request Mar 3, 2023
@SwikritiT @grgprarup
Api tests for deleting the expiration date of a space (#5606)
048f94e
phil-davis pushed a commit that referenced this pull request Mar 6, 2023
@SwikritiT @phil-davis
Api tests for deleting the expiration date of a space (#5606)
d447b05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@saw-jan saw-jan saw-jan left review comments

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@phil-davis phil-davis Awaiting requested review from phil-davis

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SwikritiT @SagarGi @saw-jan @ScharfViktor