-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Api tests for deleting the expiration date of a space #5606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwikritiT
force-pushed
the
add-tests-for-delete-expiration-spaces
branch
from
February 22, 2023 03:43
3dc0cdc
to
ef49a4a
Compare
SwikritiT
force-pushed
the
add-tests-for-delete-expiration-spaces
branch
from
February 22, 2023 03:44
ef49a4a
to
c1d4f3c
Compare
Kudos, SonarCloud Quality Gate passed! |
SwikritiT
requested review from
ScharfViktor,
grgprarup,
SagarGi,
saw-jan,
amrita-shrestha and
phil-davis
February 22, 2023 04:00
saw-jan
reviewed
Feb 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ScharfViktor
approved these changes
Feb 22, 2023
SagarGi
reviewed
Feb 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
delete-merged-branch
bot
deleted the
add-tests-for-delete-expiration-spaces
branch
February 22, 2023 11:05
ownclouders
pushed a commit
that referenced
this pull request
Feb 22, 2023
saw-jan
pushed a commit
that referenced
this pull request
Feb 28, 2023
9 tasks
grgprarup
pushed a commit
that referenced
this pull request
Mar 2, 2023
grgprarup
pushed a commit
that referenced
this pull request
Mar 3, 2023
phil-davis
pushed a commit
that referenced
this pull request
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests to remove the expiration date from a space share in user and group space share
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: