Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version command and add build information to metrics #609

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Sep 25, 2020

The cli version command for the proxy service.

@C0rby C0rby self-assigned this Sep 25, 2020
@C0rby
Copy link
Contributor Author

C0rby commented Sep 25, 2020

Argh... for some reason I didn't see the changelog folder in the proxy module.
Should I move it from the root changelog folder or what is the process now? @micbar

@micbar
Copy link
Contributor

micbar commented Sep 25, 2020

move it to the extension, yes.

Signed-off-by: David Christofas <dchristofas@owncloud.com>
Copy link
Member

@refs refs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks for porting the changes from ocis-proxy

@refs refs merged commit 3eedee5 into master Sep 28, 2020
@refs refs deleted the proxy-version-command branch September 28, 2020 08:18
@jnweiger
Copy link
Contributor

jnweiger commented Dec 2, 2020

Leaves me puzzled. How can #310 be solved using this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants