Streamline menus #656
Merged
Streamline menus #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
kulmann
commented
Oct 6, 2020
| { | ||
| ID: "accounts", | ||
| Path: "/accounts.js", | ||
| }, |
There was a problem hiding this comment.
I changed the order because it is the order in which the navItems are rendered in the respective menu. We want to settings navItem first after the Profile navItem.
kulmann
commented
Oct 6, 2020
| :value="areAllAccountsSelected" | ||
| @input="toggleSelectionAll" | ||
| :label="$gettext('Select all users')" | ||
| hide-label |
There was a problem hiding this comment.
Just fixing incorrect indentation here.
kulmann
force-pushed
the
streamline-menus
branch
from
d978d27
to
42e51e4
Compare
ownclouders
pushed a commit
that referenced
this pull request
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update phoenix for streamlining menus