Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use micro default client for connections to account service #718

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Use micro default client for connections to account service #718

merged 2 commits into from
Oct 19, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Oct 19, 2020

... was causing file descriptor leaks

@update-docs

This comment has been minimized.

Sign in to view
@kulmann kulmann self-assigned this Oct 19, 2020
@kulmann kulmann requested review from IljaN and C0rby October 19, 2020 14:44
C0rby
C0rby approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kulmann kulmann merged commit 06e75fe into master Oct 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the glauth-micro-client branch October 19, 2020 16:04
ownclouders pushed a commit that referenced this pull request Oct 19, 2020
@kulmann
commit 06e75fe
c781df0 
Merge: 1278909 271063a
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Mon Oct 19 18:03:59 2020 +0200

    Merge pull request #718 from owncloud/glauth-micro-client

    Use micro default client for connections to account service
@micbar micbar mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@IljaN IljaN Awaiting requested review from IljaN

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulmann @C0rby