Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix token storage config for web #7528

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Oct 19, 2023

Description

Bugfix: Token storage config fixed

The token storage config in the config.json for web was missing when it was set to false.

Outcome

{
    "server": "https://localhost:9200",
    "theme": "https://localhost:9200/themes/owncloud/theme.json",
    "openIdConnect": {
        "metadata_url": "https://localhost:9200/.well-known/openid-configuration",
        "authority": "https://localhost:9200",
        "client_id": "web",
        "response_type": "code",
        "scope": "openid profile email"
    },
    "apps": [
        "files",
        "search",
        "text-editor",
        "pdf-viewer",
        "external",
        "admin-settings"
    ],
    "external_apps": [
        {
            "id": "preview",
            "path": "web-app-preview",
            "config": {
                "mimeTypes": [
                    "image/tiff",
                    "image/bmp",
                    "image/x-ms-bmp",
                    "image/heic"
                ]
            }
        }
    ],
    "options": {
        "previewFileMimeTypes": [
            "image/gif",
            "image/png",
            "image/jpeg",
            "text/plain",
            "image/tiff",
            "image/bmp",
            "image/x-ms-bmp"
        ],
        "sharingRecipientsPerPage": 200,
        "sidebar": {
            "shares": {
                "showAllOnLoad": false
            }
        },
        "routing": {
            "idBased": true
        },
        "contextHelpersReadMore": true,
        "openLinksWithDefaultApp": true,
        "tokenStorageLocal": false
    }
}

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micbar
Copy link
Contributor Author

micbar commented Oct 19, 2023

@JammingBen can you confirm that this fixes the issue?

@JammingBen
Copy link
Contributor

Yep it fixes the issue!

@micbar micbar merged commit 7777dba into master Oct 20, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-token-storage-config-web branch October 20, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WEB_OPTION_TOKEN_STORAGE_LOCAL not working as expected
3 participants