Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add beta drive listing endpoints to the graph api #7861

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Nov 30, 2023

Description

add beta drive listing endpoints to the graph api and hydrate them to contain the new grantedtoV2 property and use unified roles instead of the cs3 roles.

Since the drive listing endpoints are already in use (e.g. clients), we've decided to create a new version of it and hide it behind a beta namespace.

ToDo

  • ✅ extend unified roles and use UnifiedRoleConditionOwner
  • ✅ add more unit tests

Related Issue

Motivation and Context

be able to use the new unified roles and grantedToV2 in the drive listing response.

How Has This Been Tested?

  • unit tests
  • ci tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

…e them to contain the new grantedtoV2 property and use unified roles instead of the cs3 roles
@fschade fschade self-assigned this Nov 30, 2023
Copy link

update-docs bot commented Nov 30, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@fschade fschade marked this pull request as ready for review December 5, 2023 09:42
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

77.4% 77.4% Coverage
0.0% 0.0% Duplication

@fschade fschade merged commit 34f3ab6 into owncloud:master Dec 6, 2023
4 checks passed
ownclouders pushed a commit that referenced this pull request Dec 6, 2023
* feature: add beta drive listing endpoints to the graph api and hydrate them to contain the new grantedtoV2 property and use unified roles instead of the cs3 roles

* enhancement: make use of owner conditions for drive listing

* enhancement: provide GetDrivesV1Beta1 and GetAllDrivesV1Beta1 graph endpoint tests
@micbar micbar mentioned this pull request Dec 6, 2023
22 tasks
2403905 pushed a commit to 2403905/ocis that referenced this pull request Dec 8, 2023
…7861)

* feature: add beta drive listing endpoints to the graph api and hydrate them to contain the new grantedtoV2 property and use unified roles instead of the cs3 roles

* enhancement: make use of owner conditions for drive listing

* enhancement: provide GetDrivesV1Beta1 and GetAllDrivesV1Beta1 graph endpoint tests
2403905 pushed a commit to 2403905/ocis that referenced this pull request Jan 24, 2024
…7861)

* feature: add beta drive listing endpoints to the graph api and hydrate them to contain the new grantedtoV2 property and use unified roles instead of the cs3 roles

* enhancement: make use of owner conditions for drive listing

* enhancement: provide GetDrivesV1Beta1 and GetAllDrivesV1Beta1 graph endpoint tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants