-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup driveitems.go
#8228
Cleanup driveitems.go
#8228
Conversation
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@@ -741,7 +740,7 @@ func (g Graph) getCS3UserShareByID(ctx context.Context, permissionID string) (*c | |||
return getShareResp.GetShare(), nil | |||
} | |||
|
|||
func (g Graph) updateUserShare(ctx context.Context, permissionID string, oldPermission, newPermission *libregraph.Permission) (*libregraph.Permission, error) { | |||
func (g Graph) updateUserShare(ctx context.Context, permissionID string, _, newPermission *libregraph.Permission) (*libregraph.Permission, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the oldPermissions
parameter completely from the method signature. AFAICS there is only one caller and this is some leftover that was overlooked during review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little note about the unused parameter. Other than that lgtm.
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 6 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Main intend is to use proto getters to avoid panics.
Fixes #7899
This also fixes some other issues that made my IDE sad and angry.