graph/sharedWitMe: fix response for shares from project space #8233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resources on project space do not have a real owner assigned. A special of the type USER_TYPE_SPACE_OWNER is returned as the owner. This type of user can't be looked up via a GetUser request. So we skip that call for this usertype. This also fixes the behavior of 'sharedWithMe' for case when the owner or creator of a share or shared resource can't be looked up in the 'users' service. Previously cause the complete request to fail with an error message. So a single share with an unresolvable owner caused 'sharedWithMe' to fail. Now we log a warning but return all shares. Those where the owner or creator couldn't be resolved will have the 'displayName' field of the user in the 'remoteItem.shared.owner' or 'remoteItem.shared.sharedBy' property left empty. Fixes: owncloud#8215 Fixes: owncloud#8027
|
kobergj
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources on project space do not have a real owner assigned. A special
of the type USER_TYPE_SPACE_OWNER is returned as the owner. This type of
user can't be looked up via a GetUser request. So we skip that call for
this usertype.
This also fixes the behavior of 'sharedWithMe' for case when the owner
or creator of a share or shared resource can't be looked up in the 'users'
service. Previously cause the complete request to fail with an error message.
So a single share with an unresolvable owner caused 'sharedWithMe' to fail.
Now we log a warning but return all shares. Those where the owner or creator
couldn't be resolved will have the 'displayName' field of the user in the
'remoteItem.shared.owner' or 'remoteItem.shared.sharedBy' property left
empty.
Fixes: #8215
Fixes: #8027