[docs-only] Disable proof key validation for OnlyOffice #9725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ScharfViktor
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
I checked CI. it's already disabled
https://github.com/owncloud/ocis/blob/master/.drone.star#L1003
ownclouders
pushed a commit
that referenced
this pull request
Aug 2, 2024
[docs-only] Disable proof key validation for OnlyOffice
It's disabled in CI because the wopi validator won't send the proofs, so all the requests would fail because we can't verify them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we have a lot of problems with proof keys and onlyoffice.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: