show '--' for negative file size

[individual-it]

Description

1. use toEqual to assert content, because toMatch is expecting a regex, to toMatch("") would always be true, I noticed it after I changed the code and the test still passed
2. as discussed in [QA] show 'pending' when the folder size is not yet computed #1402 show negative number as -- and not empty string

How Has This Been Tested?

unit tests

Types of changes

• Bug fix, fixes [QA] show 'pending' when the folder size is not yet computed #1402
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation added/updated

Open tasks:

• ...

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[LukasHirt]

Isn't a negative value returned if the size is being still calculated?

[individual-it]

How? 'size' should never be negative now

[pascalwengerter]

How? 'size' should never be negative now

I think he (and me as well) were wondering how a server can even return a negative value in the first place ;D

[LukasHirt]

https://central.owncloud.org/t/understanding-pending-state/6884/3

A folder appears pending if their size is "-1" in oc_filecache. It usually means that its content hasn't been scanned so the folder size is unknown since the contents size itself is also unknown.

[individual-it]

@LukasHirt thank you for the explanation, I actually did not knew that.

[individual-it]

should we show an ? if the filesize is -1?

[LukasHirt]

should we show an ? if the filesize is -1?

Good question... I think this is how oC classic is handling this case so at least for now I'd say yes, let's do so

[pascalwengerter]

FYI found this in web: https://github.com/owncloud/web/issues/2131

Not sure if pending or ? are better, we may want to add context for a11y reasons? @kulmann

[pascalwengerter]

FYI found this in web: owncloud/web#2131

Not sure if pending or ? are better, we may want to add context for a11y reasons? @kulmann

Actually transferred this issue to the ODS so this PR will close it 💪🏽

[individual-it]

I've changed it to be -- as proposed in #1402

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[pascalwengerter]

LGTM 💯 love it

[kulmann]

🚀