Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Fix sorting behaviour #1588

Merged
merged 4 commits into from
Aug 17, 2021
Merged

Fix sorting behaviour #1588

merged 4 commits into from
Aug 17, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Aug 16, 2021 •
edited
Loading

Description

This PR

  • enforces an initial sort-by value, which gets computed from the first sortable field in the list of fields in OcTableFiles
  • fixes sorting by dates by not comparing relative dates anymore, but comparing unix timestamps instead.

Related Issue

Motivation and Context

Improve UX

How Has This Been Tested?

  • added/adapted unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

@kulmann kulmann self-assigned this Aug 16, 2021
@kulmann kulmann changed the title Enforce initial sort-by Fix sorting behaviour Aug 16, 2021
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
20.0% 20.0% Duplication

pascalwengerter
pascalwengerter approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely stuff 💟

@kulmann kulmann merged commit b2c70a7 into master Aug 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-default-sort-by branch August 17, 2021 08:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

@lookacat lookacat Awaiting requested review from lookacat

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] "sort by modified date" shows mixed order
2 participants
@kulmann @pascalwengerter